Chart annotations #3724
Chart annotations #3724
Conversation
|
Hi @mwm5945. Thanks for your PR. I'm waiting for a SeldonIO or todo member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. |
|
@mwm5945 We will probably need to change https://github.com/SeldonIO/seldon-core/blob/master/operator/helm/split_resources.py rather than the template files directly as they are generated by this script from the kustomize. |
|
/assign @cliveseldon @cliveseldon updated :) |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mwm5945
force-pushed
the
chart-annotations
branch
from
b068e8b to
cf48cf4
Compare
|
/test integration |
|
/test notebooks |
2 similar comments
|
/test notebooks |
|
/test notebooks |
|
@mwm5945: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the jenkins-x/lighthouse repository. I understand the commands that are listed here. |
|
Thanks @mwm5945 ! |
| @@ -21,6 +21,9 @@ spec: | |||
| template: | |||
| metadata: | |||
| annotations: | |||
| {{- with .Values.manager.annotations }} | |||
| {{- toYaml . | nindent 4}} | |||
There was a problem hiding this comment.
❓ Couple of days late, but shouldn't this be an indent 8 spaces not 4?
There was a problem hiding this comment.
yep--i'll fix in another pr. Good catch!
* update split_resources python file * add annotations to crds * add annotations to crds * add annotations to deployment template * merge origin * update chart readme * remove deployment annotations * minor tweaks
What this PR does / why we need it: Adds configurable annotations to the CRDs and Manager deployment templates.
Which issue(s) this PR fixes:
Fixes #3699
Special notes for your reviewer:
Does this PR introduce a user-facing change?: